Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
FIX: do not report that webagg supports blitting#19762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
| @@ -116,6 +116,7 @@ def _timer_set_interval(self): | |||
| class FigureCanvasWebAggCore(backend_agg.FigureCanvasAgg): | |||
| _timer_cls = TimerTornado | |||
| supports_blit = False | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do you want to add a comment that this is a workaround, or is this tracked in an issue and planned to be fixed soon after 3.4 release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Added an inline comment.
We now implement the required underlying methods (copy_from_bbox andrestore_region), but there are issues with the double buffering in nbagg,initialization issues, and with updates to the front end being dropped.For mpl3.4.0 over-ride the class property that checks for the required methodsuntil we can fix the issues with blitting.Closesmatplotlib#19701
768c676 to0c2ae15CompareThe issue with blitting / stale draws is tracked in#19116 |
@meeseeksdev backport to v3.4.x |
…762-on-v3.4.xBackport PR#19762 on branch v3.4.x (FIX: do not report that webagg supports blitting)
We now implement the required underlying methods (copy_from_bbox and
restore_region), but there are issues with the double buffering in nbagg,
initialization issues, and with updates to the front end being dropped.
For mpl3.4.0 over-ride the class property that checks for the required methods
until we can fix the issues with blitting.
Closes#19701
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).