Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix resizing in nbAgg.#19746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jklymak merged 1 commit intomatplotlib:masterfromQuLogic:fix-nbagg-resize
Mar 22, 2021
Merged

Conversation

QuLogic
Copy link
Member

PR Summary

The WebSocket wrapper around the IPython comm does not definereadyState, and so resizes are never forwarded to the Python side.

PR Checklist

  • [n/a] Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • [n/a] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

The WebSocket wrapper around the IPython comm does not define`readyState`, and so resizes are never forwarded to the Python side.
@QuLogicQuLogic added Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. GUI: nbagg labelsMar 19, 2021
@QuLogicQuLogic added this to thev3.4.0 milestoneMar 19, 2021
@jklymak
Copy link
Member

How do we test this? Is this@ianhi issue?

@ianhi
Copy link
Contributor

Is this@ianhi issue?

@jklymak how do you mean?

I think this is a follow up to:#19131. In particular this commit:725e908 which changed things in the webagg js which nbagg relies on.

How do we test this?

Run the UAT test inlib/matplotlib/backends/web_backend. Everything should still work ideally, and when manually resizing the figure should update.

One thing that I've been adding for lots of repos working with widgets is a github bot that comments on PRs with a binder link. In this case that link is:
https://mybinder.org/v2/gh/qulogic/matplotlib/fix-nbagg-resize?filepath=lib/matplotlib/backends/web_backend/nbagg_uat.ipynb

with the more general case described here:https://mybinder.readthedocs.io/en/latest/howto/gh-actions-badges.html

I'll bet that that script could be modified to check if any files inweb_backend have been modified and then comment the appropriate binder link

Copy link
Contributor

@ianhiianhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Makes sense to me

@jklymakjklymak merged commit9efccb3 intomatplotlib:masterMar 22, 2021
@QuLogicQuLogic deleted the fix-nbagg-resize branchMarch 22, 2021 22:06
@tacaswell
Copy link
Member

@meseeksdev backport to v3.4.x

@tacaswell
Copy link
Member

@meeseeksdev backport to v3.4.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestMar 24, 2021
tacaswell added a commit that referenced this pull requestMar 24, 2021
…746-on-v3.4.xBackport PR#19746 on branch v3.4.x (Fix resizing in nbAgg.)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@jklymakjklymakjklymak approved these changes

@ianhiianhiianhi approved these changes

Assignees
No one assigned
Labels
GUI: nbaggRelease criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

4 participants
@QuLogic@jklymak@ianhi@tacaswell
[8]ページ先頭
©2009-2025 Movatter.jp