Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix Bbox.frozen() not copying minposx/minposy#19641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 2 commits intomatplotlib:masterfromsoffan-group16:issue19296
Mar 5, 2021

Conversation

m4reko
Copy link
Contributor

PR Summary

The problem that this PR resolves is thatBbox.frozen() does not copy the minpos values which is a problem when using log scaling. This shouldresolve#19296.

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • [N/A] Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • [N/A] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

Co-authored-by: Agriad <agriad1@yahoo.com>Co-authored-by: davek10 <94davek@gmail.com>Co-authored-by: tjr16 <jerryaccount@126.com>
Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping@matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

This function copies minpos when frozen is called.This commitresolvesmatplotlib#19296.Co-authored-by: Agriad <agriad1@yahoo.com>Co-authored-by: davek10 <94davek@gmail.com>Co-authored-by: tjr16 <jerryaccount@126.com>
@tacaswelltacaswell added this to thev3.5.0 milestoneMar 5, 2021
@QuLogicQuLogic merged commite7bd831 intomatplotlib:masterMar 5, 2021
@QuLogic
Copy link
Member

Thanks@m4reko! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic left review comments

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@tacaswelltacaswelltacaswell approved these changes

@anntzeranntzeranntzer approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

Bbox.frozen() does not copy minposx/minposy
4 participants
@m4reko@QuLogic@tacaswell@anntzer

[8]ページ先頭

©2009-2025 Movatter.jp