Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix Bbox.frozen() not copying minposx/minposy#19641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Co-authored-by: Agriad <agriad1@yahoo.com>Co-authored-by: davek10 <94davek@gmail.com>Co-authored-by: tjr16 <jerryaccount@126.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping@matplotlib/developers
or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join uson gitter for real-time discussion.
For details on testing, writing docs, and our review process, please seethe developer guide
We strive to be a welcoming and open project. Please follow ourCode of Conduct.
Uh oh!
There was an error while loading.Please reload this page.
This function copies minpos when frozen is called.This commitresolvesmatplotlib#19296.Co-authored-by: Agriad <agriad1@yahoo.com>Co-authored-by: davek10 <94davek@gmail.com>Co-authored-by: tjr16 <jerryaccount@126.com>
Thanks@m4reko! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. |
PR Summary
The problem that this PR resolves is that
Bbox.frozen()
does not copy the minpos values which is a problem when using log scaling. This shouldresolve#19296.PR Checklist
pytest
passes).flake8
on changed files to check).flake8-docstrings
and runflake8 --docstring-convention=all
).doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).