Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix for issue 17769: wx interactive figure close cause crash#19596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 7 commits intomatplotlib:masterfromtohc1:wx_interactive_fix
Mar 3, 2021

Conversation

tohc1
Copy link
Contributor

PR Summary

Fix for issue#17769

  1. On figure window (FigureFrameWx) close - remove figure manager from from Gcf class
    previously Gcf.destroy was called with FigureFrameWx not FigureManagerWx instance so figure was not removed correctly.

  2. Destroy now done from FigureManagerWx.destroy() method to prevent multiple calls to the close event handler.

  3. Remove unneeded wx mainloop yield calls that cause crash on windows from both FigureManagerWx.destroy and FigureFrameWx.Destroy.

Tested on windows 10, and mint 20.1.

PR Checklist

  • [N/A ] Has pytest style unit tests (andpytest passes).
  • [N/A] IsFlake 8 compliant (runflake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • [N/A ] Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • [N/A] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

1) On figure window (FigureFrameWx) close - remove figure manager from from Gcf class previously Gcf.destroy was called with FigureFrameWx not FigureManagerWx instance so figure was not removed.2) Destroy now done from FigureManagerWx.destroy() method to prevent multiple calls to the close event handler.3) Remove unneeded wx mainloop yield calls that cause crash on windows form both FigureManagerWx.destroy and FigureFrameWx.Destroy
Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping@matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

Prevent multiple attempts to close the frame by setting to FigureManagerWx.frame to None when closed by GUI.When closed by plt.close() call, the frame is closed in a threadsafe way using wx.CallAfter( frame.Close )
@tohc1
Copy link
ContributorAuthor

Slightly revised to pass thread tests.

  1. On figure window (FigureFrameWx) close - remove figure manager from from Gcf class
    previously Gcf.destroy was called with FigureFrameWx not FigureManagerWx instance so figure was not removed correctly.

  2. The frame close event handler will now, set the FigureManagerWx.frame to None to prevent Close being called again from FigureManagerWx.destroy.

  3. If closed via plt.close() the FigureManagerWx.destroy() method is called first, and will close the frame via the threadsafe wx.CallAfter call.

Other notes:
The close event handler now allows the event to propagate which will automatically destroy the Frame, and children. So the toolbar does not need to be destroyed in FigureFrameWx.Destroy()

Also the unneeded wx mainloop yield calls are removed from both FigureManagerWx.destroy and FigureFrameWx.Destroy as these cause crashes on windows.

@tacaswell
Copy link
Member

Thanks@tohc1 !

@tacaswelltacaswell added this to thev3.4.0 milestoneMar 1, 2021
tohc1and others added2 commitsMarch 2, 2021 20:09
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
Copy link
Member

@QuLogicQuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Don't know why flake8 doesn't flag this.

tohc1and others added2 commitsMarch 3, 2021 15:50
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@tacaswelltacaswell merged commitb7d57c9 intomatplotlib:masterMar 3, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestMar 3, 2021
@tacaswell
Copy link
Member

Thank you@tohc1 and congratulations on your first Matplotlib PR 🎉 Hopefully we will hear from you again!

QuLogic added a commit that referenced this pull requestMar 3, 2021
…596-on-v3.4.xBackport PR#19596 on branch v3.4.x (Fix for issue 17769: wx interactive figure close cause crash)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@QuLogicQuLogicQuLogic approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

3 participants
@tohc1@tacaswell@QuLogic
[8]ページ先頭
©2009-2025 Movatter.jp