Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

FIX: check for a set during color conversion#19583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:masterfromjklymak:fix-check-set-colors
Mar 1, 2021

Conversation

jklymak
Copy link
Member

Closes#19544 using@anntzer suggested fix....

@jklymakjklymak added topic: color/color & colormaps Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labelsFeb 25, 2021
@jklymakjklymak added this to thev3.4.0 milestoneFeb 25, 2021
@jklymakjklymakforce-pushed thefix-check-set-colors branch 2 times, most recently from851af74 to9d99c53CompareFebruary 26, 2021 01:52
@jklymak
Copy link
MemberAuthor

@mwaskom did you have a second to check if this will work? Or at least that the tests cover the cases you think are important?

@mwaskom
Copy link

My test suite passes with this change and the logic of the code looks right to me, thanks for asking.

jklymak reacted with thumbs up emoji

Co-authored-by: Antony Lee <anntzer.lee@gmail.com>
@QuLogicQuLogic merged commitfa73bc0 intomatplotlib:masterMar 1, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestMar 1, 2021
@jklymakjklymak deleted the fix-check-set-colors branchMarch 1, 2021 23:47
QuLogic added a commit that referenced this pull requestMar 2, 2021
…583-on-v3.4.xBackport PR#19583 on branch v3.4.x (FIX: check for a set during color conversion)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@mwaskommwaskommwaskom left review comments

@timhoffmtimhoffmtimhoffm left review comments

@QuLogicQuLogicQuLogic approved these changes

Assignees
No one assigned
Labels
Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.topic: color/color & colormaps
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

Regression in 3.4.0rc1 in creating ListedColormap from a set
5 participants
@jklymak@mwaskom@tacaswell@QuLogic@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp