Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix "return"->"enter" mapping in key names.#19577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
All backends previously normalized both the return key and the (numpad)enter to "enter" (see e.g. the presence of two "enter" entries in theold FigureCanvas{GTK3,Tk}.keyvald . When revamping the gtk and tk keynames lookup I accidentally normalized both to "return" instead, so fixthat.Test with```gcf().canvas.mpl_connect("key_press_event", lambda e: print(e.key))```tacaswell approved these changesFeb 25, 2021
jklymak approved these changesFeb 26, 2021
@meeseeksdev backport to v3.4.x |
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestMar 1, 2021
QuLogic added a commit that referenced this pull requestMar 2, 2021
…577-on-v3.4.xBackport PR#19577 on branch v3.4.x (Fix "return"->"enter" mapping in key names.)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
GUI: gtkGUI: tkRelease criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All backends previously normalized both the return key and the (numpad)
enter to "enter" (see e.g. the presence of two "enter" entries in the
old FigureCanvas{GTK3,Tk}.keyvald . When revamping the gtk and tk key
names lookup I accidentally normalized both to "return" instead (#17791,#18693),
so fix that.
Test with
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).