Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fail early when setting Text color to a non-colorlike.#19571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:masterfromanntzer:ccl
Feb 27, 2021

Conversation

anntzer
Copy link
Contributor

Otherwise, the error is only raised when drawing the artist, which is
always confusing. Also add a general_check_color_like mechanism and
use it for Line2D as well, instead of relying on a slightly strange
if not is_color_like(): check_in_list(get_named_colors_mapping())
call where the check_in_listalways fails.

Closes#19569 (well, likely the OP was confused about other stuff, but this should at least bring the error message closer to the relevant place).

PR Summary

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

@jklymak
Copy link
Member

but'0.82'is colorlike?

Otherwise, the error is only raised when drawing the artist, which isalways confusing.  Also add a general `_check_color_like` mechanism anduse it for Line2D as well, instead of relying on a slightly strange`if not is_color_like(): check_in_list(get_named_colors_mapping())`call where the check_in_list *always* fails.
@anntzer
Copy link
ContributorAuthor

Yes...?

@jklymak
Copy link
Member

Thats what the original bug was failing on, wasn't it?

@anntzer
Copy link
ContributorAuthor

Given that the traceback ends withValueError: Invalid RGBA argument: 'G' I guessed they have a color set to 'G' (instead of 'g') somewhere else, but without a repro it's admittedly hard to say.

jklymak reacted with thumbs up emoji

@timhoffmtimhoffm added this to thev3.4.1 milestoneFeb 27, 2021
@timhoffmtimhoffm merged commit69edfa2 intomatplotlib:masterFeb 27, 2021
@anntzeranntzer deleted the ccl branchFebruary 27, 2021 18:02
@QuLogic
Copy link
Member

Don't see why this has to go in v3.4.1.

@meeseeksdev backport to v3.4.x

@QuLogicQuLogic modified the milestones:v3.4.1,v3.4.0Mar 1, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestMar 1, 2021
tacaswell added a commit that referenced this pull requestMar 2, 2021
…571-on-v3.4.xBackport PR#19571 on branch v3.4.x (Fail early when setting Text color to a non-colorlike.)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jklymakjklymakjklymak approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

ValueError: Invalid RGBA argument: 'G'
4 participants
@anntzer@jklymak@QuLogic@timhoffm

[8]ページ先頭

©2009-2025 Movatter.jp