Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

DOC: fix typos#19567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 3 commits intomatplotlib:masterfromkatrielester:my-new-feature
Feb 25, 2021
Merged

Conversation

@katrielester
Copy link
Contributor

PR Summary

Several typos fixed. Typos are found using codespell.

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping@matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

Copy link
Member

@jklymakjklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The two non-agg spelling mistakes are fine, but I think we just vendor agg, so I wouldn't change those just for the sake of making code spell happy.

@tacaswelltacaswell added this to thev3.4.0 milestoneFeb 25, 2021
@tacaswelltacaswell merged commitce7d1cb intomatplotlib:masterFeb 25, 2021
@tacaswell
Copy link
Member

Agree with@jklymak about not changing the vendored code.

Thank you for this@katrielester ! Congratulations on your first Matplotlib PR 🎉 Hopefully we will hear from you again.

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestFeb 25, 2021
tacaswell added a commit that referenced this pull requestFeb 25, 2021
…567-on-v3.4.xBackport PR#19567 on branch v3.4.x (DOC: fix typos)
@katrielesterkatrielester deleted the my-new-feature branchFebruary 26, 2021 10:08
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@tacaswelltacaswelltacaswell approved these changes

@jklymakjklymakAwaiting requested review from jklymak

Assignees

No one assigned

Projects

None yet

Milestone

v3.4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@katrielester@tacaswell@jklymak@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp