NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.4k

Remove workaround for numpy<1.16, and update version check.#19500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

timhoffm merged 3 commits intomatplotlib:masterfromanntzer:np116

Feb 16, 2021

Merged

Remove workaround for numpy<1.16, and update version check.#19500

timhoffm merged 3 commits intomatplotlib:masterfromanntzer:np116

Feb 16, 2021

Conversation

Copy link

Contributor

anntzer commentedFeb 11, 2021

We now require numpy 1.16 (per setup.py and NEP29).

PR Summary

PR Checklist

Has pytest style unit tests (andpytest passes).
IsFlake 8 compliant (runflake8 on changed files to check).
New features are documented, with examples if plot related.
Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

Remove workaround for numpy<1.16, and update version check.

e8d9ea3

We now require numpy 1.16 (per setup.py and NEP29).

anntzer added the Maintenance label

Feb 11, 2021

anntzer added this to thev3.4.0 milestone

Feb 11, 2021

QuLogic approved these changes

Feb 11, 2021

View reviewed changes

tacaswell added2 commits

February 15, 2021 20:39

DOC: Note numpy version bump to 1.16

6b2a3f4

MNT: also bump run-time checking of pyparsing and dateutil

7558cab

Copy link

Member

tacaswell commentedFeb 16, 2021

Apparently I missed these in60b03f1 /#17662 and there is already an API note change included in that PR (which I noted after I helpfully pushed a commit to this branch to add one 🤦 ).

Also pushed a commit bumping the run-time version of pyparsing and dateutil.

Copy link

Member

timhoffm commentedFeb 16, 2021•
edited
Loading

Also pushed a commit bumping the run-time version of pyparsing and dateutil.

Are these based on

We will only bump these dependencies as we need new features or the old versions no longer support our minimum NumPy or Python.

Copy link

Member

tacaswell commentedFeb 16, 2021

Yes, the setup.py versions of dateutil and pyparsing were both bumped in#17662 (to the oldest version that did not have deprecation warnings on py36 (I think importing without warnings is a defend-able definition of "support" because otherwise we would have to protect their imports to keep our tests passing). Seedd61ed1 andcfccfb8 for details.