Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

MNT: Restore auto-adding Axes3D to their parent figure on init#19496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jklymak merged 3 commits intomatplotlib:masterfromtacaswell:fix_3D_autoadd
Feb 18, 2021

Conversation

tacaswell
Copy link
Member

@tacaswelltacaswell commentedFeb 11, 2021•
edited
Loading

Only do this when directly created by the user, not via our machinery.

PR Summary

Alternative to#19413.

This still needs tests and updates to the docs.

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

@tacaswelltacaswell added the Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labelFeb 11, 2021
@tacaswelltacaswell added this to thev3.4.0 milestoneFeb 11, 2021
@jklymak
Copy link
Member

This passes the labelled test if you go back to the old way of calling:

@mpl3d_image_comparison(['axes3d_labelpad.png'],remove_text=False)deftest_axes3d_labelpad():fig=plt.figure()ax=Axes3D(fig)

OTOH, I was hoping we would deprecate calling Axes3D this way because it really is illogical to have it behave differently from every other type of axes.

@tacaswelltacaswell marked this pull request as ready for reviewFebruary 17, 2021 21:26
@tacaswell
Copy link
MemberAuthor

I ended up going with@jklymak 's approach of a public facing kwarg (to give users a migration path), but did it via kwarg-popping so it does not show up in the signature.

I think this is a lighter touch than#19413.

@jklymakjklymak mentioned this pull requestFeb 17, 2021
7 tasks
tacaswelland others added2 commitsFebruary 17, 2021 23:06
Only warn when directly created by the user, not via our machinery.Closesmatplotlib#18939Co-authored-by: Jody Klymak <jklymak@gmail.com>Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@tacaswell
Copy link
MemberAuthor

I think I fixed the doc build (by updating a very old whats new example!).

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@jklymakjklymakjklymak approved these changes

Assignees
No one assigned
Labels
Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

3 participants
@tacaswell@jklymak@QuLogic
[8]ページ先頭
©2009-2025 Movatter.jp