Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

re-arrange mplDeprecation imports#1946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
efiring merged 2 commits intomatplotlib:masterfromtacaswell:mpldeprec_imports
Apr 29, 2013

Conversation

tacaswell
Copy link
Member

in#1917@NelleV requested I importmplDeprecation directly fromcbook. On further investigation I found that none of the current code did that.

This PR changes the import scheme to import directly from cbook everywhere.

and changed all cases offrom matplotlib import MatplotlibDeprecationWarning as mplDeprecationtofrom cbook import mplDeprecation
@NelleV
Copy link
Member

Thanks for doing this work.

You should explicitely import cbook: either usefrom .cbook import blah orfrom matplotlib.cbook import blah.
I personnally prefer the first version, but matplotlib's codebase uses the latter (and it is the recommanded way of importing a intra package module).

@tacaswell
Copy link
MemberAuthor

Should lines like

iterable = cbook.iterableis_string_like = cbook.is_string_likeis_sequence_of_strings = cbook.is_sequence_of_strings

(fromaxes.py) be changed tofrom matplotlib.cbook import blah ?

@NelleV
Copy link
Member

I think it would be cleaner, but I think this is a question of personal taste so I'll leave it up to you.

@tacaswell
Copy link
MemberAuthor

My inclination is to not change code that works, so I will leave it ;)

efiring added a commit that referenced this pull requestApr 29, 2013
@efiringefiring merged commit3b972d6 intomatplotlib:masterApr 29, 2013
@tacaswelltacaswell deleted the mpldeprec_imports branchApril 29, 2013 20:35
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@tacaswell@NelleV@efiring
[8]ページ先頭
©2009-2025 Movatter.jp