Has pytest style unit tests (andpytest passes).
IsFlake 8 compliant (runflake8 on changed files to check).
New features are documented, with examples if plot related.
Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

DOC: fix an overlooked docs change frommatplotlib#19153

1606570

lpsinger mentioned this pull request

Feb 2, 2021

Unexpected change in behavior in plt.subplot#19432

Closed

dstansby requested changes

Feb 2, 2021

View reviewed changes

Copy link

Member

dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We can't just get rid of these docs without deprecating the behaviour it documents (if indeed we do want to change the behaviour, which I'm not sure we do in this case), in particular

Meanwhile, if you do not want this behavior (i.e., you want to force the creation of a new subplot), you must use a unique set of args and kwargs.

Copy link

Contributor

astrofrog commentedFeb 2, 2021

I'm very concerned about this change, even if it was to go through a deprecation phase. As indicated in#19432 I don't understand why one would ever want the same axes to be returned if the projection and kwargs are different?

dstansby added Documentation Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labels

Feb 2, 2021

Copy link

Member

dstansby commentedFeb 2, 2021

I don't think I can dismiss my review, but if another maintainer wants to then go ahead. Apologies for jumping the gun on lots of this discussion, that has clearly been discussed more thoroughly on a dev call. I've tagged this as release critical so we don't forget it either way.