Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Updated patch to not override alpha on edgecolor if set to none#1938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Hmmm. I'm not sure about this. This will result in some strange behaviour. The following two snippets will behave very differently:
It may be that the work stemming from#1899 should address this problem when dealing with alpha and color definitions. |
@pelson: You are correct. The problem is that there is no special color designation for no edge. Instead 'none' gets translated in Thereal solution I see is no allow a color designation of none. But that is not straightforward with the current code that I can see. There are three posibilities I can readily see:
Do you think one of the three is the way to go or do you see an alternative approach? |
Actually, the way |
Sounds good to me. I will close this PR |
Thanks to@cimarronm and@Westacular for looking into this murky part of color handling 😄 |
Addresses issue#1934.