Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix specgram test on NumPy 1.20.#19371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dstansby merged 1 commit intomatplotlib:masterfromQuLogic:fix-np120
Jan 27, 2021
Merged

Conversation

QuLogic
Copy link
Member

@QuLogicQuLogic commentedJan 27, 2021
edited
Loading

PR Summary

In NumPy 1.20, the fft is slightly different (more accurate?) and returns 0 as the last entry, instead of some small number ~1e-30. This causes a divide-by-zero warning inlog10. However, this test doesn't really care about the spectrogram, just the frequencies, so we can change the scale to linear to avoid the warning.

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • [n/a] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogicQuLogic added this to thev3.3.4 milestoneJan 27, 2021
In NumPy 1.20, the fft is slight different (more accurate?) and returns0 as the last entry, instead of some small number ~1e-30. This causes adivide-by-zero warning in `log10`. However, this test doesn't reallycare about the spectrogram, just the frequencies, so we can change thescale to linear to avoid the warning.
@dstansbydstansby merged commit7cfdbe1 intomatplotlib:masterJan 27, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestJan 27, 2021
jklymak added a commit that referenced this pull requestJan 27, 2021
…371-on-v3.3.xBackport PR#19371 on branch v3.3.x (Fix specgram test on NumPy 1.20.)
@QuLogicQuLogic deleted the fix-np120 branchJanuary 27, 2021 21:51
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jklymakjklymakjklymak approved these changes

@dstansbydstansbydstansby approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.3.4
Development

Successfully merging this pull request may close these issues.

3 participants
@QuLogic@jklymak@dstansby

[8]ページ先頭

©2009-2025 Movatter.jp