Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Deprecate imread() reading from URLs#19367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
e60a11c to9302392Compare| @@ -1128,7 +1129,8 @@ def test_exact_vmin(): | |||
| @pytest.mark.network | |||
| @pytest.mark.flaky | |||
| def test_https_imread_smoketest(): | |||
| v = mimage.imread('https://matplotlib.org/1.5.0/_static/logo2.png') | |||
| with _api.suppress_matplotlib_deprecation_warning(): | |||
| v = mimage.imread('https://matplotlib.org/1.5.0/_static/logo2.png') | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Shouldn't you properly fix this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The point is that after the removal, reading this just won't involve matplotlib at all (it'll bePIL.Image.open(urllib.request.urlopen(...)), so the whole test will go away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
oops sorry - I missed what the test was for....
I pushed a point release, but feel free to push back if this is really urgent. |
I don't think we should introduce new deprecation in bugfix releases, so this should either be 3.4.0, or, if it can't make it, 3.5.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Seems fine. Feel free to re0milestone if there is a second review
PR Summary
Replaces#18649, with the suggestion to directly using the Pillow API (#18649 (review)).Closes#18648.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).