Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Enh improve agg chunks error#19343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

tacaswell
Copy link
Member

PR Summary

This does 2 important things:

  • makes the errors when you exceed the chunk size more instructive of how to fix your problem
  • makes the upper limit higher so it will be hit less often

and 2 less important things:

  • makes a test more pathological
  • makes sure the simplification threshold is propagated when chunking.

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).

@tacaswelltacaswell added this to thev3.5.0 milestoneJan 23, 2021
@jklymakjklymak marked this pull request as draftMay 10, 2021 16:29
@tacaswelltacaswellforce-pushed theenh_improve_agg_chunks_error branch from150617a to6cfa6edCompareMay 27, 2021 00:06
@tacaswelltacaswell marked this pull request as ready for reviewMay 27, 2021 00:06
@tacaswelltacaswellforce-pushed theenh_improve_agg_chunks_error branch fromc01a41d to52f7610CompareMay 27, 2021 00:19
@jklymakjklymak marked this pull request as draftJune 8, 2021 21:03
@tacaswelltacaswellforce-pushed theenh_improve_agg_chunks_error branch from52f7610 toc19d49fCompareAugust 5, 2021 18:03
@tacaswelltacaswell marked this pull request as ready for reviewAugust 5, 2021 18:03
@tacaswelltacaswell marked this pull request as draftAugust 5, 2021 23:54
@tacaswelltacaswellforce-pushed theenh_improve_agg_chunks_error branch fromc19d49f to51ae0a8CompareSeptember 8, 2021 20:17
@tacaswelltacaswell marked this pull request as ready for reviewSeptember 16, 2021 19:25
tacaswelland others added5 commitsSeptember 22, 2021 15:19
The error messages now provide better instruction on how to fix theproblem.There are some paths we can not split (one with hatching, fills, orthat claim they can not be simplified) so tell user that.If we could have otherwise split up the path if the chunksize is setto less than 100, which disables the feature, ask user to make itbigger or make the path simplification more aggressive.If the chunksize is bigger than the data, ask user to make it smalleror make the path simplification more aggressive.If the chunksize is smaller than the data, but still too big ask userto make it smaller or make the path simplification more aggressive.closesmatplotlib#19325Co-authored-by: Antony Lee <anntzer.lee@gmail.com>
This allows longer, more textured, paths to be drawn with the defaultsettings at the risk of very long run times.
- Make sure values are be big enough / small enough- make long path test more pathological (Random data will sometimes go in the  same direction)
@tacaswelltacaswellforce-pushed theenh_improve_agg_chunks_error branch from51ae0a8 to09fa321CompareSeptember 22, 2021 19:19
Copy link
Member

@dstansbydstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I've had a look over and it looks good - there's one change I don't understand at all though (left a comment) so I'm not personally comfortable approving yet.

@@ -45,7 +45,7 @@ RendererAgg::RendererAgg(unsigned int width, unsigned int height, double dpi)
rendererBase(),
rendererAA(),
rendererBin(),
theRasterizer(8192),
theRasterizer(32768),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What's the meaning of this change?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

And does it need documenting in an API change note?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

That is:

  • makes the upper limit higher so it will be hit less often

@QuLogicQuLogic merged commit1357c52 intomatplotlib:masterSep 25, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestSep 25, 2021
QuLogic added a commit that referenced this pull requestSep 25, 2021
…343-on-v3.5.xBackport PR#19343 on branch v3.5.x (Enh improve agg chunks error)
tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull requestOct 12, 2021
tacaswell pushed a commit that referenced this pull requestOct 20, 2021
@tacaswelltacaswell deleted the enh_improve_agg_chunks_error branchNovember 30, 2021 04:11
@tacaswelltacaswell mentioned this pull requestDec 5, 2022
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@anntzeranntzeranntzer left review comments

@dstansbydstansbydstansby left review comments

@QuLogicQuLogicQuLogic approved these changes

@jklymakjklymakjklymak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

5 participants
@tacaswell@QuLogic@anntzer@jklymak@dstansby
[8]ページ先頭
©2009-2025 Movatter.jp