NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

MarkerStyle is considered immutable#19341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

jklymak merged 1 commit intomatplotlib:masterfromtimhoffm:immutable-marker

Jan 28, 2021

Merged

MarkerStyle is considered immutable#19341

jklymak merged 1 commit intomatplotlib:masterfromtimhoffm:immutable-marker

Jan 28, 2021

Conversation

Copy link

Member

timhoffm commentedJan 22, 2021•
edited
Loading

PR Summary

as discussed in yesterdays dev call.

jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Overall makes sense to me, but it seemslines.set_fillstyle is not tested? Or did you want to deprecate that as well?

lib/matplotlib/lines.py

		@@ -534,7 +534,7 @@ def set_fillstyle(self, fs):

		For examples see :ref:`marker_fill_styles`.
		"""
		self._marker.set_fillstyle(fs)
		self.set_marker(MarkerStyle(self._marker.get_marker(), fs))

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I guess we never testset_fillstyle? Can we use this as the opportunity to do so?

Copy link

MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'd like to have this deprecation be part of 3.4 and I don't know if I have the bandwidth to add tests soon. Therefore, I'd rather do this in a later PR.

Copy link

MemberAuthor

timhoffm commentedJan 25, 2021•
edited
Loading

As opposed to what I said in the dev call, we cannot easily deprecateLines.set/get_fillstyle. I thoughtget_marker() would return theMarkerStyle so that we could doline.get_marker().get_fillstyle(). However, the usedMarkerStyle object is not public.get_marker() does not return it but only the marker symbol, e.g.'o'.

Therefore, I'll leave marker and fillstyle as "simple" Matplotlib properties ofLine2D for now.