Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix several CI issues#19301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 3 commits intomatplotlib:masterfromQuLogic:fix-azure
Jan 15, 2021
Merged

Fix several CI issues#19301

QuLogic merged 3 commits intomatplotlib:masterfromQuLogic:fix-azure
Jan 15, 2021

Conversation

QuLogic
Copy link
Member

@QuLogicQuLogic commentedJan 14, 2021•
edited
Loading

PR Summary

  • Fix brew installation on Azure pipelines.
  • Don't allow pyzmq 21.0.0 on AppVeyor.
    This version is broken on Windows:fix bundling msvcp on Python 3.9 zeromq/pyzmq#1470.
  • TST: Mark Cairo backends as not threadsafe.
    Cairo backends save thecairo_t object on the graphics context (as
    self.gc.ctx), but this object is not threadsafe.
    This should fix sporadic failures intest_interactive_thread_safety.

PR Checklist

  • [n/a] Has pytest style unit tests (andpytest passes).
  • [n/a] IsFlake 8 compliant (runflake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • [n/a] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogicQuLogic changed the titleFix brew installation on Azure pipelines.Fix Azure pipelines and AppVeyor CIJan 14, 2021
@QuLogicQuLogic changed the titleFix Azure pipelines and AppVeyor CIFix several CI issuesJan 14, 2021
Cairo backends save the `cairo_t` object on the graphics context (as`self.gc.ctx`), but this object is not threadsafe.
backend,
marks=pytest.mark.xfail(reason='github #16849'))
marks.append(pytest.mark.xfail(reason='github #16849'))
backend = pytest.param(backend, marks=marks)
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This change ensures we always have apytest.param, so that the later loop is simpler.

Copy link
Member

@tacaswelltacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Anyone can merge on green.

@QuLogicQuLogic merged commit491e2a7 intomatplotlib:masterJan 15, 2021
@QuLogicQuLogic deleted the fix-azure branchJanuary 15, 2021 00:46
@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.3.x$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 491e2a7e40c1cc92f6816ab03c9df12bae5ab46e
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #19301: Fix several CI issues'
  1. Push to a named branch :
git push YOURFORK v3.3.x:auto-backport-of-pr-19301-on-v3.3.x
  1. Create a PR against branch v3.3.x, I would have named this PR:

"Backport PR#19301 on branch v3.3.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free tosuggest an improvement.

QuLogic added a commit to QuLogic/matplotlib that referenced this pull requestJan 15, 2021
QuLogic added a commit that referenced this pull requestJan 15, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.3.4
Development

Successfully merging this pull request may close these issues.

2 participants
@QuLogic@tacaswell
[8]ページ先頭
©2009-2025 Movatter.jp