Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Cleanup and document _plot_args()#19278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
f7aa29d to2ba1c58CompareTest failure is unredated (segfault in PyQt). |
| @@ -417,16 +458,16 @@ def _plot_args(self, tup, kwargs, return_kwargs=False): | |||
| raise ValueError("x, y, and format string must not be None") | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This would never have checked whetherfmt is None, because of the first if, is it not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
For(x, y, None), you ended up with the "third arg must be a format string" error. But for(y, None) this check triggers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ah yes, because the length checks are different.
Uh oh!
There was an error while loading.Please reload this page.
PR Summary