Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
handle usecase where QT_API is specified with some capitals#19245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
not too sure where to set QT_API so that this gets tested. I couldn't find anywhere obvious where |
I don't think it is; it's very difficult to get all backends available on CI to test that. |
QuLogic approved these changesJan 6, 2021
timhoffm approved these changesJan 7, 2021
Thanks! |
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestJan 7, 2021
…d with some capitals
QuLogic added a commit that referenced this pull requestJan 7, 2021
…245-on-v3.3.xBackport PR#19245 on branch v3.3.x (handle usecase where QT_API is specified with some capitals)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
I'm not sure why this never triggered an error before.
But we set this environment variable by accident once and I didn't fully understand the error message.
It seems that the QT_API_ENV is expected to be lowercase, but it doesn't really convert the user's potentially uppercase option to lowercase.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).