Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

FIX: process lists for inverse norms#19240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

jklymak
Copy link
Member

PR Summary

Closes#19239 by processing the input for inverse as well as__call__ for_make_norm_from_scale

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

@jklymakjklymak added this to thev3.4.0 milestoneJan 5, 2021
@jklymakjklymakforce-pushed thefix-process-inverse-norm branch fromb308574 todf33f03CompareJanuary 5, 2021 02:51
Copy link
Member

@QuLogicQuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Not sure how much my review counts since this is what I suggested, but you could consider it@jklymak's reverse review of what I wrote.

@QuLogicQuLogic requested a review fromanntzerJanuary 5, 2021 05:09
Co-authored-by: QuLogic <quantum.analyst@gmail.com>
@jklymakjklymakforce-pushed thefix-process-inverse-norm branch fromdf33f03 toab34279CompareJanuary 5, 2021 05:36
@jklymak
Copy link
MemberAuthor

Yes, sorry, I should have put you in the commit message... I think I did it right...

@anntzer
Copy link
Contributor

can merge postci

@jklymakjklymak merged commit7da6d1c intomatplotlib:masterJan 5, 2021
@jklymakjklymak deleted the fix-process-inverse-norm branchJanuary 5, 2021 17:31
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@anntzeranntzeranntzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

_make_norm_from_scale needs to process values
3 participants
@jklymak@anntzer@QuLogic
[8]ページ先頭
©2009-2025 Movatter.jp