Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Ignore closepoly vertices in _update_patch_limits.#19159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

Arun12121
Copy link

PR Summary

This PR removes CLOSEPOLY vertices from the list of vertices used to find the data limits in _update_patch_limits.
Fixes#19078.

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • [N/A] Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • [N/A] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

tol = 16*sys.float_info.epsilon
ax.add_patch(mpatches.Wedge((0, -1), 1.05, 60, 120, 0.1))
bounds = ax.dataLim.bounds
bot = 1.9*math.sin(15*math.pi/180)**2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just use numpy for these rather than importingmath? You may also want to look atnp.testing.assert_allclose rather than writing your own tolerance.

@jklymak
Copy link
Member

Did you mean to close this?

@dopplershift
Copy link
Contributor

Likely made obsolete by#19088...

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jklymakjklymakjklymak left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_update_patch_limits should not use CLOSEPOLY verticies for updating
3 participants
@Arun12121@jklymak@dopplershift

[8]ページ先頭

©2009-2025 Movatter.jp