Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix WebAgg initialization#19131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
+1 −4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This is already done in the WebSocket's `onopen` function, and sendingit during the object's initialization crashes due to the WebSocket notbeing ready.Fixesmatplotlib#19129.
Because this is behind the asynchronous `ResizeObserver`, it does _not_cause a failure to initialize the JavaScript figure, but is similar inerror as the previous commit.
attn@ianhi |
tacaswell approved these changesDec 16, 2020
I tested locally and this works again. |
ianhi approved these changesDec 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This fixes the issue for me as well.
I'm going to merge on the strength of@ianhi review and this being a critical fix. |
Not sure why this didn't backport? @meeseeksdev backport to v3.3.x |
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestDec 17, 2020
QuLogic pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestDec 22, 2020
QuLogic added a commit that referenced this pull requestDec 22, 2020
…131-on-v3.3.xBackport PR#19131 on branch v3.3.x (Fix WebAgg initialization)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
GUI: webaggRelease criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sending the pixel ratio in initialization fails because the WebSocket is not open yet; this is already sent in the
onopenhandler, so just remove it from initialization.Also, fix a similar bug in sending resizes too early. This one is non-fatal because it is in an async handler.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).