Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix WebAgg initialization#19131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 2 commits intomatplotlib:masterfromQuLogic:fix-webagg
Dec 17, 2020
Merged

Conversation

QuLogic
Copy link
Member

PR Summary

Sending the pixel ratio in initialization fails because the WebSocket is not open yet; this is already sent in theonopen handler, so just remove it from initialization.

Also, fix a similar bug in sending resizes too early. This one is non-fatal because it is in an async handler.

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • [n/a] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

This is already done in the WebSocket's `onopen` function, and sendingit during the object's initialization crashes due to the WebSocket notbeing ready.Fixesmatplotlib#19129.
Because this is behind the asynchronous `ResizeObserver`, it does _not_cause a failure to initialize the JavaScript figure, but is similar inerror as the previous commit.
@QuLogicQuLogic added this to thev3.3.4 milestoneDec 16, 2020
@tacaswell
Copy link
Member

attn@ianhi

@tacaswell
Copy link
Member

I tested locally and this works again.

@tacaswelltacaswell added the Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labelDec 17, 2020
Copy link
Contributor

@ianhiianhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This fixes the issue for me as well.

@tacaswell
Copy link
Member

I'm going to merge on the strength of@ianhi review and this being a critical fix.

@tacaswelltacaswell merged commit9372073 intomatplotlib:masterDec 17, 2020
@QuLogicQuLogic deleted the fix-webagg branchDecember 17, 2020 22:09
@QuLogic
Copy link
MemberAuthor

Not sure why this didn't backport?

@meeseeksdev backport to v3.3.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestDec 17, 2020
QuLogic pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestDec 22, 2020
QuLogic added a commit that referenced this pull requestDec 22, 2020
…131-on-v3.3.xBackport PR#19131 on branch v3.3.x (Fix WebAgg initialization)
@ianhiianhi mentioned this pull requestMar 22, 2021
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@ianhiianhiianhi approved these changes

Assignees
No one assigned
Labels
GUI: webaggRelease criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.3.4
Development

Successfully merging this pull request may close these issues.

3 participants
@QuLogic@tacaswell@ianhi
[8]ページ先頭
©2009-2025 Movatter.jp