Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
GOV/DOC: add section to docs on triaging and triage team#19124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
3c5d156
to55904c0
CompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
@dopplershift@timhoffm@efiring This is on the agenda for today, but if you guys are OK with adding a "triage" layer to the Membership then you can hit approve. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Just one typo.
Looks good to me.
doc/devel/triage.rst Outdated
or privately) to recommend you to the triage team . If you worked | ||
with someone on the issue triaged, they would be a good person to | ||
ask. | ||
3. Responsibly exercise you new power! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
you -> your
I will merge this when docs pass CI. |
Testing @matplotlib/triageteam notification. |
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>Co-authored-by: hannah <story645@gmail.com>
PR Summary
This adds documentation to add a "triage team" to our organization as discussed on today's call. The purpose of this is to:
This text is based onhttps://scikit-learn.org/dev/developers/bug_triaging.html and modified to better fit Matplotlib.
Task that need to be done immediately outside of a PR if we merge this:
If this catches on we may want to:
On the call I suggested 1 triage would be the threshold to be invited, but ended up with 2-3 just so that we have a bit more context to evaluate. Being optomistic, I expect most of these requests / nominations to be fulfilled.
sklearn has a slightly higher bar for inviting people to the triage team (https://scikit-learn.org/dev/governance.html#triage-team) and more ceremony, but I would rather have this be broader and less formal.
We can deal with bad-faith actors if they come up and I expect a vast majority of the issues we will have will be miss-labeled or miss-milestoned issues which are almost trivially fixable.