Are you sure about that? The test is still failing.

@QuLogic and I talked through this today. The issue is:

• The HTMLWriter inherits from FileMovieWritter which sets up a non-context manager TemporaryDirectory in the in init
• However the cleanup code is not called (because the super class cleanup code does things that do not make sense for HTMLWriter)
• we do not see this failure on the default branch because sometime after we branched v3.3.x off the tests got cleaned up a best and the object that triggers the failure is now created in a fixture so is escaping this pytest logic that converts un-handled exceptions into failures.

This code probably should on the main branch, we will handle that with a careful merge up.

It looks like there's another failure in pgf due to theLatexManager teardown. There is a weakref finalizer for thePopen added by@anntzer in#18679, but it doesn't appear to have been called early enough.

#18679 doesn't appear to have been backported, and I guess it basically fixed the bug that is now getting exposed by pytest?

I tried to backport the non-deprecation related changes.

I think I missed these failures locally because I have other pgf failures due to latex changing under us (I see this on Arch, assume we will see it in test containers eventually, but that is a problem for the future).

Ah, sorry, I was looking atmaster instead ofv3.3.x.