Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix failing animation test with pytest 6.2.#19108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:masterfromanntzer:animtests
Dec 14, 2020

Conversation

anntzer
Copy link
Contributor

... perhttps://docs.pytest.org/en/stable/usage.html#unraisable.

PR Summary

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

@timhoffmtimhoffm added this to thev3.3.4 milestoneDec 14, 2020
@timhoffmtimhoffm merged commit5ab99ee intomatplotlib:masterDec 14, 2020
@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.3.x$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 5ab99eee3d605b782ea51262e461fb3e837b3039
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #19108: Fix failing animation test with pytest 6.2.'
  1. Push to a named branch :
git push YOURFORK v3.3.x:auto-backport-of-pr-19108-on-v3.3.x
  1. Create a PR against branch v3.3.x, I would have named this PR:

"Backport PR#19108 on branch v3.3.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free tosuggest an improvement.

@anntzeranntzer deleted the animtests branchDecember 14, 2020 02:27
timhoffm added a commit to timhoffm/matplotlib that referenced this pull requestDec 14, 2020
tacaswell added a commit that referenced this pull requestDec 22, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jklymakjklymakjklymak approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.3.4
Development

Successfully merging this pull request may close these issues.

3 participants
@anntzer@jklymak@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp