Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Switch AxisArtist to use standard tick directions.#19102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
i.e. defaulting to "out". Also support "inout".Would perpendicular work better for "out"? see e.g.demo_curvelinear_grid.
leejjoon commentedNov 16, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
My recollection is that this is to test if the axislabel and the ticklabels are on the same side. If |
I just realized that this is a two-year old PR. It would be still good if this can be merged after some more fix. I can work on it if that is desired. |
@leejjoon Feel free to pick it up; it was essentially a proof of concept in reply to#19101. |
For this, I'd like to introduce However, I don't think these are good choice of option names. Any recommendation? |
I would perhaps call this tick_orientation={"parallel", "normal", "auto"}. Perhaps@timhoffm can chime in? |
Superseded by#24553. |
i.e. defaulting to "out". Also support "inout".
I had this patch lying around, and am only posting it because of#19101 (which this implements). Although tests pass, there are a few remaining points:
The default change (to "out"), as well as the new feature, have to be documented.
There is one point in the old implementation which I do not understand:
I don't understand the conditions in which the pad are zero or nonzero, and don't know either whether the second branch of the
or
should actually useminor_ticks
twice instead ofminor_ticks
and thenmajor_ticks
. Thus I don't know either how the check should be adapted for the "inout" case.I feel like it would actually look much nicer to have ticks perpendicular to the spines?
attn@jasondet I guess, feel free to pick up the patch.
PR Summary
PR Checklist
pytest
passes).flake8
on changed files to check).flake8-docstrings
and runflake8 --docstring-convention=all
).doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).