NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Ignore CLOSEPOLY vertices when computing dataLim from patches#19088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

QuLogic merged 6 commits intomatplotlib:masterfromjsberg-bnl:issue-19078

Dec 24, 2020

Merged

Ignore CLOSEPOLY vertices when computing dataLim from patches#19088

QuLogic merged 6 commits intomatplotlib:masterfromjsberg-bnl:issue-19078

Dec 24, 2020

Conversation

Copy link

jsberg-bnl commentedDec 9, 2020•
edited
Loading

PR Summary

CLOSEPOLY verticies are not actual points in a path, but _update_patch_limits uses them anyhow when computing dataLim. This patch removes the CLOSEPOLY vertices from the list of vertices used in the computation.Fixes#19078.

PR Checklist

Has pytest style unit tests (andpytest passes).
IsFlake 8 compliant (runflake8 on changed files to check).
[N/A] New features are documented, with examples if plot related.
[N/A] Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
[N/A] Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
[N/A] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
[N/A] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).