Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Always pass integers to wx.Size.#19052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 1 commit intomatplotlib:masterfromQuLogic:wx-int
Dec 16, 2020
Merged

Conversation

QuLogic
Copy link
Member

PR Summary

Fixes test failure on Python 3.10,https://bugzilla.redhat.com/show_bug.cgi?id=1902382

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • [n/a] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogicQuLogic added this to thev3.4.0 milestoneDec 1, 2020
@tacaswell
Copy link
Member

Whyceil instead offloor?

@anntzer
Copy link
Contributor

Why ceil instead of floor?

(It would be nice to document once and for all how floating-point canvas sizes (which can legitimately occur e.g. with vector backends) are supposed to be handled by backends that only support integer sizes (typically raster backends).)

@QuLogic
Copy link
MemberAuthor

Because that's what's already done here:

FigureCanvasBase.__init__(self,figure)
w,h=map(math.ceil,figure.bbox.size)
# Set preferred window size hint - helps the sizer, if one is connected
wx.Panel.__init__(self,parent,id,size=wx.Size(w,h))

@tacaswelltacaswell merged commite03d956 intomatplotlib:masterDec 16, 2020
@QuLogicQuLogic deleted the wx-int branchDecember 16, 2020 19:56
@QuLogic
Copy link
MemberAuthor

@meeseeksdev backport to v3.3.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestJan 27, 2021
@QuLogicQuLogic modified the milestones:v3.4.0,v3.3.4Jan 27, 2021
tacaswell added a commit that referenced this pull requestJan 27, 2021
…052-on-v3.3.xBackport PR#19052 on branch v3.3.x (Always pass integers to wx.Size.)
@QuLogicQuLogic mentioned this pull requestJan 29, 2021
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@dopplershiftdopplershiftdopplershift approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
v3.3.4
Development

Successfully merging this pull request may close these issues.

4 participants
@QuLogic@tacaswell@anntzer@dopplershift
[8]ページ先頭
©2009-2025 Movatter.jp