Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Start testing using GitHub Actions#19036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This is currently Linux-only, and skips caching and code coverage.
This was ignored on Travis for some time.
On Travis, NumPy was already installed and happened to be 1.16.4,roundabout our desired minimum version. On GitHub Actions, NumPy is notinstalled and gets installed later, since it was never specified in thecommand with the pins.Also, add minimum Pillow to the pins.
Test coverage is up 0.81%, though library coverage is down 5% since the build on#17524? It looks like that drop may be because C code was added back into the count. |
bb8d25a to36b73ccCompare@QuLogic I'm fine with you self-merging this if we don't hear from@tacaswell. Looks good, but I'm not an expert on the testing infrastructure. |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free tosuggest an improvement. |
Backport PR#19036 on branch v3.3.x
PR Summary
I don't think we've gotten back any reply from Travis yet. This ports Linux and macOS builds over to GitHub Actions; it takes roughly the same build time overall, though the queue might be shorter. I'm not entirely sure whether I used the right keys for caching or if it's really very effective yet.
I believe interactive backend tests are running though, so this should restore our code coverage results.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).