Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Templatize class factories.#19033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 2 commits intomatplotlib:masterfromanntzer:class-factories
May 26, 2021
Merged

Conversation

@anntzer
Copy link
Contributor

@anntzeranntzer commentedNov 27, 2020•
edited
Loading

This makes mpl_toolkits axes classes picklable (see test_pickle) by
generalizing the machinery of _picklable_subplot_class_constructor,
which would otherwise have had to be reimplemented for each class
factory.

PR Summary

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

@anntzeranntzerforce-pushed theclass-factories branch 4 times, most recently frome6165b6 to66de640CompareNovember 27, 2020 17:23
@QuLogicQuLogic added this to thev3.5.0 milestoneNov 28, 2020
@jklymakjklymak marked this pull request as draftMay 9, 2021 00:44
@anntzeranntzer marked this pull request as ready for reviewMay 9, 2021 09:42
@anntzer
Copy link
ContributorAuthor

rebased, should be good to go.

@anntzeranntzerforce-pushed theclass-factories branch 5 times, most recently fromb12a53e to788162dCompareMay 9, 2021 12:34
@jklymak
Copy link
Member

Since the song and dance was for cartopy do we know it works for them now?@dopplershift@QuLogic

@dopplershift
Copy link
Contributor

Examples seem to run fine (and there are no new test failures) with this PR + CartoPy master.

jklymak reacted with thumbs up emoji

@anntzer
Copy link
ContributorAuthor

rebased

@anntzeranntzer marked this pull request as ready for reviewMay 24, 2021 20:08
@jklymakjklymak marked this pull request as draftMay 26, 2021 14:53
This makes mpl_toolkits axes classes picklable (see test_pickle) bygeneralizing the machinery of _picklable_subplot_class_constructor,which would otherwise have had to be reimplemented for each classfactory.
@jklymakjklymak marked this pull request as ready for reviewMay 26, 2021 15:00
@jklymakjklymak requested a review fromQuLogicMay 26, 2021 15:00
@QuLogic
Copy link
Member

But I guess now that things have reasonable names, they're no longer linking in docs?

@anntzer
Copy link
ContributorAuthor

Indeed, updated missing-references.

@QuLogicQuLogic merged commit464dcf6 intomatplotlib:masterMay 26, 2021
@anntzeranntzer deleted the class-factories branchMay 26, 2021 23:48
@anntzeranntzer mentioned this pull requestJul 27, 2021
7 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@QuLogicQuLogicQuLogic approved these changes

@jklymakjklymakjklymak approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@anntzer@jklymak@dopplershift@QuLogic
[8]ページ先頭
©2009-2025 Movatter.jp