Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Remove individual doc entries for some methods Axes inherits from Artist#19025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The methods are directly inherited, so don't need a separate doc entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't have a clear view how to reasonably handle inherited methods so that they are still reasonably discoverable (IIRC there's a separate discussion somewhere).
For this particular case however, it's reasonable to not list the given methods.get/set_contains
is deprecated anyway, and I suppose there's little need for picking an Axes. It's better to remove them to reduce clutter.
The methods are directly inherited, so don't need a separate doc entry. (See#14960 for a longer discussion of a similar case.)
PR Summary
PR Checklist
pytest
passes).flake8
on changed files to check).flake8-docstrings
and runflake8 --docstring-convention=all
).doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).