Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove individual doc entries for some methods Axes inherits from Artist#19025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:masterfromanntzer:inherited-axes-methods
Nov 27, 2020

Conversation

anntzer
Copy link
Contributor

The methods are directly inherited, so don't need a separate doc entry. (See#14960 for a longer discussion of a similar case.)

PR Summary

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

The methods are directly inherited, so don't need a separate doc entry.
Copy link
Member

@timhoffmtimhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't have a clear view how to reasonably handle inherited methods so that they are still reasonably discoverable (IIRC there's a separate discussion somewhere).

For this particular case however, it's reasonable to not list the given methods.get/set_contains is deprecated anyway, and I suppose there's little need for picking an Axes. It's better to remove them to reduce clutter.

@timhoffmtimhoffm added this to thev3.4.0 milestoneNov 27, 2020
@timhoffmtimhoffm merged commit0fc0e1d intomatplotlib:masterNov 27, 2020
@anntzeranntzer deleted the inherited-axes-methods branchNovember 28, 2020 11:40
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

2 participants
@anntzer@timhoffm

[8]ページ先頭

©2009-2025 Movatter.jp