This moves attribute sorting fromPath3DCollection.do_3d_projection into a newdraw method. Sorted attributes are added only temporarily, so there is no reason to cache the original values anywhere, and thus all overridden setters can be dropped.

Draft because I will try and apply this to every 3D artist.

PR Checklist

Has pytest style unit tests (andpytest passes).
IsFlake 8 compliant (runflake8 on changed files to check).
[n/a] New features are documented, with examples if plot related.
[n/a] Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
[n/a] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
[n/a] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

QuLogic added the topic: mplot3d label

Nov 11, 2020

QuLogic added this to thev3.4.0 milestone

Nov 11, 2020

QuLogic mentioned this pull request

Nov 11, 2020

3D collections do not proper handleedgecolor='face'#18931

Closed

QuLogic added2 commits

November 11, 2020 01:34

Split attribute sorting into Path3DCollection.draw.

6293052

This moves attribute sorting from `Path3DCollection.do_3d_projection`into a new `draw` method. Sorted attributes are added only temporarily,so there is no reason to cache the original values anywhere, and thusall overridden setters can be dropped.

Split attribute sorting into Patch3DCollection.draw.

52fd461

This moves attribute sorting from `Patch3DCollection.do_3d_projection`into a new `draw` method. Sorted attributes are added only temporarily,so there is no reason to cache the original values anywhere, and thusall overridden setters can be dropped.

QuLogic force-pushed the3d-draw branch fromeb2f892 to52fd461Compare

November 11, 2020 06:35

QuLogic modified the milestones:v3.4.0,v3.5.0

Jan 22, 2021

QuLogic mentioned this pull request

Mar 2, 2021

create set_offsets3d for PathCollection3d#19573

Draft

7 tasks

QuLogic mentioned this pull request

Mar 31, 2021

FIX: size and color rendering for Path3DCollection#19812

Merged

QuLogic modified the milestones:v3.5.0,v3.6.0

Aug 23, 2021

timhoffm modified the milestones:v3.6.0,unassigned

Apr 30, 2022

QuLogic mentioned this pull request

Sep 20, 2022

[ENH]: do_3d_projection could restore original verts order after draw() finishes#23155

Closed

story645 modified the milestones:unassigned,needs sorting

Oct 6, 2022

github-actionsbot added the status: needs rebase label

Oct 18, 2022

tacaswell mentioned this pull request

Nov 18, 2022

Make Path3DCollection store indexed offset, and only apply z-ordered offset during draw#24491

Merged

1 task

Copy link

github-actionsbot commentedSep 6, 2023

Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it.