Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

FIX: make sure scalarmappable updates are handled correctly in 3D#18929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 4 commits intomatplotlib:masterfromtacaswell:fix_3D_scatter
Nov 11, 2020

Conversation

tacaswell
Copy link
Member

@tacaswelltacaswell commentedNov 10, 2020
edited
Loading

PR Summary

Code from a debugging session on the phone with@QuLogic

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

@tacaswelltacaswell added this to thev3.3.3 milestoneNov 10, 2020
@tacaswelltacaswellforce-pushed thefix_3D_scatter branch 2 times, most recently from1036193 toc9c0d38CompareNovember 10, 2020 22:04
@QuLogic
Copy link
Member

I don't think you want to rename attributes that way, as#18592 is going to do the opposite.

Copy link
Member

@QuLogicQuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Revert renames, due to the above comment. Also, unmark draft?

@tacaswell
Copy link
MemberAuthor

I did the renames because the 3D collections were inconsistent between each other. I pushed to plural to match the 2D version, will push them the other way.

@tacaswell
Copy link
MemberAuthor

Because we have a shortage of people to review mplot3D, this being a critical bug, and in the interest of getting 3.3.3 out@QuLogic can merge this at his discretion on a single review.

Copy link
Member

@QuLogicQuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Plus flake8 issues.

tacaswelland others added2 commitsNovember 11, 2020 14:35
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@QuLogicQuLogic changed the titleFIX: make sure scalarmappable updates are handleded correctly in 3DFIX: make sure scalarmappable updates are handled correctly in 3DNov 11, 2020
@QuLogicQuLogic merged commitfa54783 intomatplotlib:masterNov 11, 2020
@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.3.x$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 fa547835c7ea262b706f8bdde5bb7433ccef4f79
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #18929: FIX: make sure scalarmappable updates are handled correctly in 3D'
  1. Push to a named branch :
git push YOURFORK v3.3.x:auto-backport-of-pr-18929-on-v3.3.x
  1. Create a PR against branch v3.3.x, I would have named this PR:

"Backport PR#18929 on branch v3.3.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free tosuggest an improvement.

QuLogic added a commit to QuLogic/matplotlib that referenced this pull requestNov 11, 2020
@QuLogicQuLogic mentioned this pull requestNov 11, 2020
tacaswell added a commit that referenced this pull requestNov 11, 2020
@tacaswelltacaswell deleted the fix_3D_scatter branchMay 6, 2021 23:04
@tacaswelltacaswell restored the fix_3D_scatter branchMay 6, 2021 23:04
@tacaswelltacaswell deleted the fix_3D_scatter branchMay 6, 2021 23:04
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.3.3
Development

Successfully merging this pull request may close these issues.

2 participants
@tacaswell@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp