Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Getting Started GSoD#18873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
jeromefv wants to merge0 commits intomatplotlib:masterfromjeromefv:getting_started

Conversation

jeromefv
Copy link
Contributor

@jeromefvjeromefv commentedNov 2, 2020•
edited
Loading

PR Summary

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

@story645story645 marked this pull request as draftNovember 2, 2020 20:09
@jeromefv
Copy link
ContributorAuthor

Ah, it appears as though I had commits from other contributors from the upstream included. I'm not quite sure how to deal with those at the moment.

@jeromefv
Copy link
ContributorAuthor

I think what I had tried to do made it much messier with all of the items in Files Changed from the soft reset of commits.

@jeromefvjeromefvforce-pushed thegetting_started branch 2 times, most recently frombbebb16 toe3b45ecCompareNovember 16, 2020 21:31
@jeromefvjeromefv marked this pull request as ready for reviewDecember 2, 2020 19:19
@jeromefv
Copy link
ContributorAuthor

Ugh, I knew I messed up again... I couldn't remember how to rebase properly with my original local branch and now it's back to the messed up problem I had before. I apologize for dropping the ball on this PR.

@story645
Copy link
Member

Is alright, git is a massive pain. Ping on gitter as needed!

jeromefv reacted with thumbs up emoji

@jklymak
Copy link
Member

Until you know what you are doing, always back your branch up before doing a rebase. Then you can repeat until you get it right.

story645 reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell left review comments

@QuLogicQuLogicQuLogic left review comments

@story645story645Awaiting requested review from story645

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

6 participants
@jeromefv@story645@jklymak@tacaswell@QuLogic@brunobeltran
[8]ページ先頭
©2009-2025 Movatter.jp