Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Cleanup interactive pan/zoom.#18847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:masterfromanntzer:pz
Nov 24, 2020
Merged

Cleanup interactive pan/zoom.#18847

QuLogic merged 1 commit intomatplotlib:masterfromanntzer:pz
Nov 24, 2020

Conversation

anntzer
Copy link
Contributor

Store all the relevant state in a single dict (_pan_info), similar
to the one used for zoom (_zoom_info), instead of scattering it
in two attributes (_button_pressed/_xypress). Slightly reorder
logic inpress_pan to match the order inpress_zoom; likewise sync
release_pan withrelease_zoom.

We don't need to store the axes index (as was done in_xypress).

Inrelease_zoom, move the less-than-5px check out of the loop, as it
only needs to be done once.

PR Summary

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogic
Copy link
Member

I don't know what's wrong with Azure; maybe a rebase is needed?

Store all the relevant state in a single namedtuple (`_pan_info`),similar to the one used for zoom (`_zoom_info`), instead of scatteringit in two attributes (`_button_pressed`/`_xypress`).  Slightly reorderlogic in `press_pan` to match the order in `press_zoom`; likewise sync`release_pan` with `release_zoom`.We don't need to store the axes index (as was done in `_xypress`).In `release_zoom`, move the less-than-5px check out of the loop, as itonly needs to be done once.
@anntzer
Copy link
ContributorAuthor

namedtuple it is, then.

@QuLogicQuLogic merged commitda66560 intomatplotlib:masterNov 24, 2020
@QuLogicQuLogic added this to thev3.4.0 milestoneNov 24, 2020
@anntzeranntzer deleted the pz branchNovember 24, 2020 07:36
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

3 participants
@anntzer@QuLogic@timhoffm

[8]ページ先頭

©2009-2025 Movatter.jp