Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
wx backend API cleanups.#18680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
wx backend API cleanups.#18680
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
| with no replacement; ``gui_repaint`` now automatically detects the case where | ||
| it is used with the wx renderer. | ||
| The ``NavigationToolbar2Wx.get_canvas`` method is deprecated; copy its |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What's the motivation to deprecate this. Getting the canvas seems like a useful action, andtype(toolbar.canvas)(frame, -1, figure) is pretty arcane.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That method is not present on any of the other backends NavigationToolbar classes, and I'd rather try to make the NavToolbar API consistent across classes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would leave outtype here, and use the explicit class instead.
| with no replacement; ``gui_repaint`` now automatically detects the case where | ||
| it is used with the wx renderer. | ||
| The ``NavigationToolbar2Wx.get_canvas`` method is deprecated; copy its |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would leave outtype here, and use the explicit class instead.
- Deprecate origin kwarg to wx gui_repaint(). It's really just a slightly obscure way to add a special-path for the (long deprecated) wx backend, which can be done more explicitly.- Deprecate unused NavigationToolbar2Wx.get_canvas.
sure |
Deprecate origin kwarg to wx gui_repaint(). It's really just a
slightly obscure way to add a special-path for the (long deprecated)
wx backend, which can be done more explicitly.
Deprecate unused NavigationToolbar2Wx.get_canvas.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsandpydocstyle<4and runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).