Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Remove unused/deprecated AVConv_ classes#18666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
Tranquilled wants to merge2 commits intomatplotlib:masterfromTranquilled:failing-tests
Closed

Remove unused/deprecated AVConv_ classes#18666

Tranquilled wants to merge2 commits intomatplotlib:masterfromTranquilled:failing-tests

Conversation

Tranquilled
Copy link
Contributor

PR Summary

Removes AVConvBase et al. and a related method in FFMpegBase that refers to a deprecated Ubuntu release. The deprecation warnings (which raise errors during tests) say that these classes will be removed by version 3.5, and they don't seem to be used by any other code in this version.

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • Conforms to Matplotlib style conventions (installflake8-docstrings andpydocstyle<4 and runflake8 --docstring-convention=all).
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogic
Copy link
Member

3.4 is not out yet, so unfortunately, this cannot be done until then.

Copy link
Member

@QuLogicQuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Things deprecated in 3.3 cannot be removed until 3.5.

@Tranquilled
Copy link
ContributorAuthor

Things deprecated in 3.3 cannot be removed until 3.5.

That's fair. Can I just leave the branch here until then? I notice that the circleCI tests are failing, anyway.

@QuLogic
Copy link
Member

Sure, but you would need to fix the doc build before it is eventually merged.

@QuLogic
Copy link
Member

Also, removals should get anAPI note.

@jklymakjklymak marked this pull request as draftOctober 6, 2020 00:41
@jklymak
Copy link
Member

I'm not clear how we resurface this whenever 3.5 comes out....

@dopplershift
Copy link
Contributor

By milestoning for 3.5?

@dopplershiftdopplershift added this to thev3.5.0 milestoneOct 6, 2020
@jklymak
Copy link
Member

Fair - I wasn't sure what our milestone guidelines were.

@QuLogic
Copy link
Member

This can go in now, but it needs an API note.

@QuLogic
Copy link
Member

Thanks for the PR, but this was complete in#20465.

@QuLogicQuLogic closed thisJul 6, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic requested changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

4 participants
@Tranquilled@QuLogic@jklymak@dopplershift
[8]ページ先頭
©2009-2025 Movatter.jp