Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Allow Type3 subsetting of otf fonts in pdf backend.#18651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I guess a test font file would be too large; the linked issue is fixed. The text cannot be selected though, which seems a slight regression. On the other, it's actually displaying the right character glyphs now.
See#18517 (review) re: text selection. I think it would be very hard to have that working, and in any case I'd say correct but unselectable glyphs is better than incorrect but selectable glyphs :) |
This is supported since19359c1, results in smaller files (*much*smaller when using CJK fonts), and avoids running into issues with type42 embedding and certain pdf readers such as Acrobat Reader.
rebased |
This is supported since19359c1, results in smaller files (much
smaller when using CJK fonts), and avoids running into issues with type
42 embedding and certain pdf readers such as Acrobat Reader.
Closes#12636.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsandpydocstyle<4and runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).