I'd like to change various properties of an errorplot using a Qt figureoptions dialogue. This dialog is presented when NavToolBar is created. At the momenterrorplots do not show up in the Curves tab, so one can't change their colour, markersize, etc.
This PR detects if an ErrorbarCollection is present, and adds it to the Curves popup list. This permits adjustment of the line/marker properties of the 'host' Line. Pragmatically the bars/caps of theerrorplot are set to be the same color as the host Line, and the same linewidth of the host Line.

fixes#18631

PR Checklist

Has pytest style unit tests (andpytest passes).
IsFlake 8 compliant (runflake8 on changed files to check).
New features are documented, with examples if plot related.
[N/A] Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
[N/A] Conforms to Matplotlib style conventions (installflake8-docstrings andpydocstyle<4 and runflake8 --docstring-convention=all).
New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
[N/A] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

ENH: errorbar in qt figureoptions

72e9c8c

Copy link

ContributorAuthor

andyfaff commentedOct 4, 2020

Possibly the most controversial change is adding a generator to flatten a nested sequence, I added this to make it easier to grab all the lines out ofErrorbarCollection.lines.

Copy link

Member

QuLogic commentedOct 6, 2020

There is aflatten inmatplotlib.cbook.

Copy link

ContributorAuthor

andyfaff commentedOct 6, 2020

I'll remove the flatten I added, and use the other one. Otherwise is the PR in a suitable form?

MAINT: refactor flatten

a03e224

Copy link

ContributorAuthor

andyfaff commentedOct 10, 2020

@QuLogic refactored to useflatten frommatplotlib.cbook

MAINT: figureoptions restrict to errorbar

db84f5f

QuLogic added New feature GUI: Qt labels

Oct 16, 2020

QuLogic reviewed

Oct 16, 2020

View reviewed changes

lib/matplotlib/backends/qt_editor/figureoptions.py OutdatedShow resolvedHide resolved

MAINT: cbook.flatten

683caf6

QuLogic added the status: needs rebase label

Apr 5, 2021

jklymak marked this pull request as draft

April 23, 2021 16:57

Copy link

Member

jklymak commentedApr 23, 2021

Who is our figureoption guru? I've never used it, but hopefully someone will step up and shepherd this.

Copy link

github-actionsbot commentedAug 23, 2023

Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it.