Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Deprecate imread() reading from URLs#18649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
96ac787 to53a1b1fComparerecyclying to get doc build to rerun... |
53a1b1f to5b132aaCompare| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| Passing a URL to `~.pyplot.imread()` is deprecated. Please open the URL before | ||
| reading using ``urllib.request.urlopen()``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
As part of the standard library, shouldn't this be link-able?
The user also has to do a bit more jiggery-pokery than just The documented incantation needs to be I suspect we should also abandon most of the png guessing code and just let pillow infer as much as it wants to. I think this would make our code simpler (as it is almost a completed drop-through to pillow) and make it more functional (it will open things other than png from a url). I am 👍 on deprecating this, but we need to provide more guidance about what to replace it with. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Needs better docs on path away from imread.
Should probably also have, "UsePIL.image.open(urlopen(url))" as an option too.
👍 on the suggestions. Anybody, feel free to amend. I'm not in word-picking mood right now. |
close in favour of#19367 |
PR Summary
Closes#18648.