Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Simplify Colorbar.set_label, inline Colorbar._edges.#18645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jklymak merged 1 commit intomatplotlib:masterfromanntzer:cbar
Oct 3, 2020

Conversation

anntzer
Copy link
Contributor

set_label can just forward everything to eitherset_xlabel or
set_ylabel, which already have all the logic for handlingloc,
instead of duplicating that logic.

_edges is really just a call tonp.dstack, and factoring it to a
separate function doesn't really help legibility.

PR Summary

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • Conforms to Matplotlib style conventions (installflake8-docstrings andpydocstyle<4 and runflake8 --docstring-convention=all).
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

`set_label` can just forward everything to either `set_xlabel` or`set_ylabel`, which already have all the logic for handling `loc`,instead of duplicating that logic.`_edges` is really just a call to `np.dstack`, and factoring it to aseparate function doesn't really help legibility.
@jklymakjklymak added this to thev3.4.0 milestoneOct 3, 2020
@jklymakjklymak merged commit825f518 intomatplotlib:masterOct 3, 2020
@anntzeranntzer deleted the cbar branchOctober 3, 2020 15:18
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jklymakjklymakjklymak approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

3 participants
@anntzer@jklymak@timhoffm

[8]ページ先頭

©2009-2025 Movatter.jp