Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
BLD: certifi is not a run-time dependency#18636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
I don't remember exactly, but I think I added certifi to runtime because of the download-from-URL style handling. Since this only affected wheel builders, I don't think you'll see whether that's broken from our usual CI. |
We shouldn't let our build details leak into user space though. If the issue is just our wheel builders we should fix it there by pre-installing like we do with numpy. I am very hesitant to do it now (because the space is still moving really fast), but eventually we are going to have to have a look at pep517 and friends.... |
now this and ##18637 are going to clash, but will deal with that when it happens. |
This one should be merged first to make the backport easier. |
…636-on-v3.3.xBackport PR#18636 on branch v3.3.x (BLD: certifi is not a run-time dependency)
Actually itis a runtime dependency, e.g. |
Inmatplotlib#18636 we removed certifi as a runtime dependency, but it turns outwe do try to use it if you read from a url in a handful of places.This makes us fail gracefully and log if we can not import certifi.
PR Summary
Closes#18337