Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

BLD: certifi is not a run-time dependency#18636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

tacaswell
Copy link
Member

PR Summary

Closes#18337

@tacaswelltacaswell added this to thev3.3.3 milestoneOct 2, 2020
@QuLogic
Copy link
Member

I don't remember exactly, but I think I added certifi to runtime because of the download-from-URL style handling. Since this only affected wheel builders, I don't think you'll see whether that's broken from our usual CI.

@tacaswell
Copy link
MemberAuthor

We shouldn't let our build details leak into user space though. If the issue is just our wheel builders we should fix it there by pre-installing like we do with numpy.

I am very hesitant to do it now (because the space is still moving really fast), but eventually we are going to have to have a look at pep517 and friends....

@tacaswell
Copy link
MemberAuthor

now this and ##18637 are going to clash, but will deal with that when it happens.

@tacaswell
Copy link
MemberAuthor

This one should be merged first to make the backport easier.

@QuLogicQuLogic merged commit80c40b8 intomatplotlib:masterOct 2, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestOct 2, 2020
QuLogic added a commit that referenced this pull requestOct 3, 2020
…636-on-v3.3.xBackport PR#18636 on branch v3.3.x (BLD: certifi is not a run-time dependency)
@anntzer
Copy link
Contributor

Actually itis a runtime dependency, e.g.imread("https://matplotlib.org/1.5.0/_static/logo2.png") nowrequires certifi to be present. In fact I think that 1) this should not actually depend on certifi and 2) we should not support directly opening urls anyways...

@tacaswelltacaswell deleted the bld_intall_dep_certifi branchOctober 5, 2020 21:47
tacaswell added a commit to tacaswell/matplotlib that referenced this pull requestOct 6, 2020
Inmatplotlib#18636 we removed certifi as a runtime dependency, but it turns outwe do try to use it if you read from a url in a handful of places.This makes us fail gracefully and log if we can not import certifi.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.3.3
Development

Successfully merging this pull request may close these issues.

Error installing matplotlib-3.3.1 using pip due to old version of certifi on conda environment
4 participants
@tacaswell@QuLogic@anntzer@timhoffm

[8]ページ先頭

©2009-2025 Movatter.jp