Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix singleshot timers in wx.#18621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
`TimerWx._timer_set_single_shot` currently tries to start the timerwithout interval or any other setting, which is not what this method issupposed to do; it should only modify settings on internal objects.Since single shot mode is fully handled in `TimerWx._timer_start`, thismethod is unnecessary.
dopplershift approved these changesOct 1, 2020
gonesurfing commentedOct 1, 2020
Can confirm, this fixes the issue. Thanks! |
This is a 3.3 regression, should be backported? |
Did something else change in how timers worked? That wx code has been there much much longer than 3.3. |
Ah, looks like#17160 started using the setter on @meeseeksdev backport to v3.3.x |
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestOct 2, 2020
QuLogic added a commit that referenced this pull requestOct 2, 2020
…621-on-v3.3.xBackport PR#18621 on branch v3.3.x (Fix singleshot timers in wx.)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
TimerWx._timer_set_single_shotcurrently tries to start the timer without interval or any other setting, which is not what this method is supposed to do; it should only modify settings on internal objects. Since single shot mode is fully handled inTimerWx._timer_start, this method is unnecessary.Fixes#18620.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsandpydocstyle<4and runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).