Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Change *subplot(111, ...) to *subplot(...) as 111 is the default.#18552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
story645 merged 1 commit intomatplotlib:masterfromtimhoffm:doc-subplots
Sep 24, 2020

Conversation

timhoffm
Copy link
Member

@timhoffmtimhoffm commentedSep 23, 2020
edited
Loading

Partly re-does#17335.

Doing everything in one action seems a bit much since every occurrence must be checked. There some rare cases in which we want to leave the numbers in or want to do something else.

All changes are either in tutorials/examples, docstrings, comments or tests.

Copy link
Member

@story645story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Some questions out of curiosity but they're not blockers

@@ -259,7 +259,7 @@ def f(t):

###############################################################################
# The `~.pyplot.figure` call here is optional because
# ``figure(1)`` will be created by default, just as a ``subplot(111)``
# ``figure(1)`` will be created by default, just as a ``subplot()``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Does this need the figure(1)

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No. I've rewritten the sentence to make more sense. But don't get me started, otherwise I'll rewrite the whole tutorial 😝.

story645 reacted with laugh emoji
@story645story645 merged commit3e88c9f intomatplotlib:masterSep 24, 2020
@timhoffmtimhoffm deleted the doc-subplots branchSeptember 24, 2020 06:30
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@story645story645story645 approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

2 participants
@timhoffm@story645

[8]ページ先頭

©2009-2025 Movatter.jp