Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Correctly remove support for \stackrel.#18533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 3 commits intomatplotlib:masterfromanntzer:unstackrel
Sep 21, 2020

Conversation

anntzer
Copy link
Contributor

PR Summary

This was done incompletely inc4d3cd4 (3.3), after which\stackrel{x}{y}
just behaved (incorrectly) likexy.

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

@anntzeranntzer added this to thev3.3.3 milestoneSep 20, 2020
This was done incompletely inc4d3cd4, after which `\stackrel{x}{y}`just behaved (incorrectly) like `xy`.
Copy link
Member

@timhoffmtimhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Failed test (azure py37) seeme unrelated.

@QuLogicQuLogic merged commitaa82b50 intomatplotlib:masterSep 21, 2020
@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.3.x$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 aa82b50c349d3b8dcc6daac964aa06106aa1d0f6
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #18533: Correctly remove support for \\stackrel.'
  1. Push to a named branch :
git push YOURFORK v3.3.x:auto-backport-of-pr-18533-on-v3.3.x
  1. Create a PR against branch v3.3.x, I would have named this PR:

"Backport PR#18533 on branch v3.3.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free tosuggest an improvement.

@anntzeranntzer deleted the unstackrel branchSeptember 22, 2020 07:37
QuLogic added a commit to QuLogic/matplotlib that referenced this pull requestOct 13, 2020
timhoffm added a commit that referenced this pull requestOct 14, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.3.3
Development

Successfully merging this pull request may close these issues.

4 participants
@anntzer@tacaswell@timhoffm@QuLogic
[8]ページ先頭
©2009-2025 Movatter.jp