Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

DOC: reword non-monotonic cell center warning#18483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:masterfromjklymak:doc-reword-warning
Sep 15, 2020

Conversation

jklymak
Copy link
Member

PR Summary

Slight modification to the warning in#18398.

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • Conforms to Matplotlib style conventions (installflake8-docstrings andpydocstyle<4 and runflake8 --docstring-convention=all).
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

@jklymakjklymakforce-pushed thedoc-reword-warning branch 2 times, most recently from48cc170 to3ab4146CompareSeptember 14, 2020 20:39
Copy link
Member

@timhoffmtimhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No very strong opinion, but here's another wording:

The input coordinates to {funcname} are interpreted as cell centers but are not monotonically increasing or decreasing. This may lead to wrongly calculated mesh cell edges. In such a case, please supply explicit cell edges to {funcname}.

@jklymak
Copy link
MemberAuthor

Thanks@timhoffm - edited yours a bit, but that is better.

@dopplershift
Copy link
Contributor

Doesn't look like you updated the expected text in the test?

@QuLogicQuLogic changed the titleDOC: reword non-monotinc cell center warningDOC: reword non-monotonic cell center warningSep 15, 2020
@QuLogic
Copy link
Member

I pushed a fix to the tests, as this is the last thing for 3.3.2.

jklymak reacted with thumbs up emoji

@QuLogicQuLogic merged commit7429c2b intomatplotlib:masterSep 15, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestSep 15, 2020
QuLogic added a commit that referenced this pull requestSep 15, 2020
…483-on-v3.3.xBackport PR#18483 on branch v3.3.x (DOC: reword non-monotonic cell center warning)
@greglucas
Copy link
Contributor

I like these wording changes, thanks for fixing that up!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm left review comments

@dopplershiftdopplershiftdopplershift approved these changes

@QuLogicQuLogicQuLogic approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.3.2
Development

Successfully merging this pull request may close these issues.

5 participants
@jklymak@dopplershift@QuLogic@greglucas@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp