This line came in viab2a80a7 /#1589 . It looks like everything still passes without it (!!) so I think that means either we never needed it or the work done since then on the colorbar code has made it redundant.

PR Checklist

Has pytest style unit tests (andpytest passes).
IsFlake 8 compliant (runflake8 on changed files to check).
[N/A ] New features are documented, with examples if plot related.
[N/A] Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
Conforms to Matplotlib style conventions (installflake8-docstrings andpydocstyle<4 and runflake8 --docstring-convention=all).
[N/A] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
[N/A] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

tacaswell added this to thev3.4.0 milestone

Sep 7, 2020

jklymak approved these changes

Sep 8, 2020

View reviewed changes

Copy link

Member

jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks, good, though I don't understand why you added an import 😉

lib/matplotlib/tests/test_axes.pyShow resolvedHide resolved

lib/matplotlib/tests/test_axes.py Outdated

Comment on lines 6522 to 6523

		fig = Figure()
		ax = fig.gca()

Copy link

Member

jklymakSep 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	fig=Figure()
	ax=fig.gca()
	fig,ax=plt.subplots()

Copy link

MemberAuthor

tacaswell commentedSep 8, 2020

I was intentionally writing the tests to not invoke the pyplot machinery to see how it feels.

Copy link

Member

jklymak commentedSep 8, 2020

I was intentionally writing the tests to not invoke the pyplot machinery to see how it feels.

It feels like you had to do an extra import for no good reason. 😉 I'm not blocking, but I'd usefig.add_subplots() rather thangca() if we want to develop good grammar for this?

Copy link

Member

timhoffm commentedSep 22, 2020

I'm ok with the extra import, but agree, thatfig.add_subplots() would be better thangca(), the latter being too pyploty.

On a general note: What is the motivation to leave out pyplot? Is there a perfromance benefit, or is it the desire to reduce the dependency on pyplot. Is there a plan to move larger parts of the tests away from pyplot?