Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add example for specifying figure size in different units#18360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jklymak merged 1 commit intomatplotlib:masterfromtimhoffm:doc-figsize
Aug 26, 2020

Conversation

timhoffm
Copy link
Member

PR Summary

This explains and illustrates best practices for working with figure sizes in units differing from the default inches.

This addresses the user needs of#12402 as good as possible without introducing new API.

Copy link
Member

@jklymakjklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks helpful. A few suggestions?


matplotlib.pyplot.figure
matplotlib.pyplot.subplots
matplotlib.pyplot.subplot_mosaic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Not used?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is to trigger theback links which I think is useful here (as these are the entry points where we want people to use to set the figure size)?

timhoffm reacted with thumbs up emoji
# conversion almost look like appending a unit to the number, which is nicely
# readable.
#
cm = 1/2.54 # cm in inches
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I was 90% sure this was exact, but had to look it up to be 100% sure. You may want to indicate that with a link tohttps://en.wikipedia.org/wiki/Inch? and/or more decimal places? Or at least say its exact?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

IMHO that'd be overly cautious. One should assume that code/logic is correct unless explicitly indicated as an approximation. I'd really feel awkward adding something like "Look, what we're doing is really correct. Here is the proof".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

OK, but doing1/2.5400 wouldn't hurt?

@jklymakjklymak added this to thev3.4.0 milestoneAug 26, 2020
@jklymakjklymak merged commitc035f66 intomatplotlib:masterAug 26, 2020
@timhoffmtimhoffm deleted the doc-figsize branchAugust 27, 2020 06:08
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell left review comments

@jklymakjklymakjklymak left review comments

@QuLogicQuLogicQuLogic approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

4 participants
@timhoffm@tacaswell@QuLogic@jklymak
[8]ページ先頭
©2009-2025 Movatter.jp